Hi Pierre-Louis > After this series of patches is applied, we have this in soc.h: > > struct snd_soc_dai *codec_dai; > struct snd_soc_dai *cpu_dai; > > struct snd_soc_dai **codec_dais; > unsigned int num_codecs; > > struct snd_soc_dai **cpu_dais; > unsigned int num_cpus; > > What is the intent behind keeping the two fields codec_dai and cpu_dai? > > Shouldn't we use the multi-dai structures in all cases, possible > degraded to a single element rather than maintaining what looks like > duplicate ways of accessing the same element? > > If removing these fields across all drivers is just too invasive for > now, shouldn't we start defining access macros so that those fields > can be deprecated and removed at a later time, platform-by-platform? Actually, I have this patch (= remove cpu_dai/codec_dai from all drivers, and use macro for it), and have plan to post it. But, I have many extra cleanup patches in my tree, and I want to post it before that (to avoid extra re-ordering dpendency break). Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
