Re: [PATCH v6] ASoC: Add MediaTek MT6660 Speaker Amp Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 14 Jan 2020 13:47:44 +0100,
Mark Brown wrote:
> 
> On Tue, Jan 14, 2020 at 08:44:22AM +0100, Takashi Iwai wrote:
> > Jeff Chang wrote:
> 
> > > +	if (ret < 0)
> > > +		return ret;
> > > +	reg_data = (u8)ret;
> > > +	if (on_off)
> > > +		reg_data &= (~0x01);
> > > +	else
> > > +		reg_data |= 0x01;
> > > +	return regmap_write(chip->regmap, MT6660_REG_SYSTEM_CTRL, reg_data);
> 
> > Hm, this looks like an open-code of forced update bits via regmap.
> > But interestingly there is no corresponding standard helper for that.
> > Essentially it should be regmap_update_bits_base() with force=1.
> 
> > Mark?
> 
> regmap_write_bits().

Oh that obvious one, thanks :)


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux