On Tue, Jan 14, 2020 at 08:44:22AM +0100, Takashi Iwai wrote: > Jeff Chang wrote: > > + if (ret < 0) > > + return ret; > > + reg_data = (u8)ret; > > + if (on_off) > > + reg_data &= (~0x01); > > + else > > + reg_data |= 0x01; > > + return regmap_write(chip->regmap, MT6660_REG_SYSTEM_CTRL, reg_data); > Hm, this looks like an open-code of forced update bits via regmap. > But interestingly there is no corresponding standard helper for that. > Essentially it should be regmap_update_bits_base() with force=1. > Mark? regmap_write_bits().
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel