At Tue, 18 Sep 2007 15:57:41 +0200, Rene Herman wrote: > > On 09/18/2007 01:54 PM, Takashi Iwai wrote: > > > Let's leave seq_instr as is. It's a never-working concept. The only > > user is OPL3, and this should be rewritten using hwdep. Then we'll > > get rid of this whole code chunk. > > Well, if you insist, but thought I'd submit is seperately once again. The > schedule_timeout() calls in there are so-so, will simply not schedule, but that > > while (instr->use) > schedule_timeout(1); > > loop is dangerous. There's nothing that I can see that's stopping the > compiler from turning this into an infinite loop: > > if (instr->use) > while (1) > schedule_timeout(1); > > I'll admit I have no idea where this code ends up, but if it's _ever_ used > this seems to not be good. Fair enough, I merged it. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
