Re: [PATCH] sun-cs4231: code improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Sun, 2 Sep 2007 22:16:15 +0200,
Krzysztof Helt wrote:
> 
> From: Krzysztof Helt <krzysztof.h1@xxxxx>
> 
> This patch does some code improvements to make
> driver (both code and binary) shorter.
> It also make use of card->private_data pointer to
> store chip information.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx>

The change looks OK.  But, again, please fix "if ((err = ...))", at
least, for the lines we change.


Thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux