Re: [PATCH] dbri: conversion to OpenFirmware framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Sun, 2 Sep 2007 09:31:09 +0200,
Krzysztof Helt wrote:
> 
> From: Krzysztof Helt <krzysztof.h1@xxxxx>
> 
> This patch converts the dbri driver to use OF framework.
> 
> Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx>
> 
> ---
> 
> This patch requires the previous dbri patch with more
> code improvements posted yesterday.

The conversion from __init to __devinit is still missing in some
places.  This could result in oops.

Otherwise the change looks almost good to me.  But, please fix
"if ((err = ...))" if you change that line, too :)


thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux