On 8/9/07, Joachim Förster <mls.JOFT@xxxxxx> wrote: > From: Joachim Foerster <JOFT@xxxxxx> > > Add ALSA support for the opb_ac97_controller_ref_v1_00_a ip core found > in Xilinx' ML403 reference design. > > Known issue: Currently this driver hits a WARN_ON_ONCE(1) statement in > kernel/irq/resend.c (line 70). According to Linus > (http://lkml.org/lkml/2007/8/5/5) this may be ignored, right? I haven't > had a look into this "problem" yet. > > (Patch for Linus' master branch, date 2007/08/08) > > This patchset _will_ be published on > http://www.esic-solutions.com/support.html soon (like the first version > of the driver (tar file), but this may take some days ...). Comments below > diff --git a/sound/ppc/Makefile b/sound/ppc/Makefile > index eacee2d..827f2f5 100644 > --- a/sound/ppc/Makefile > +++ b/sound/ppc/Makefile Couldn't this end up on MicroBlaze too? If so, sound/ppc is the wrong place. > @@ -4,7 +4,9 @@ > # > > snd-powermac-objs := powermac.o pmac.o awacs.o burgundy.o daca.o tumbler.o keywest.o beep.o > +snd-ml403_ac97cr-objs := ml403_ac97cr.o This line is only needed if you're compiling multiple .c files into one .ko > > # Toplevel Module Dependency > obj-$(CONFIG_SND_POWERMAC) += snd-powermac.o > obj-$(CONFIG_SND_PS3) += snd_ps3.o > +obj-$(CONFIG_SND_ML403_AC97CR) += snd-ml403_ac97cr.o > diff --git a/sound/ppc/ml403_ac97cr.c b/sound/ppc/ml403_ac97cr.c > new file mode 100644 > index 0000000..99791d7 > --- /dev/null > +++ b/sound/ppc/ml403_ac97cr.c > @@ -0,0 +1,1274 @@ > + > +/* ALSA driver for Xilinx ML403 AC97 Controller Reference > + * IP: opb_ac97_controller_ref_v1_00_a (EDK 8.1i) > + * IP: opb_ac97_controller_ref_v1_00_a (EDK 9.1i) > + * > + * Copyright (c) by 2007 Joachim Foerster <JOFT@xxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > + * > + */ > + > +#include <sound/driver.h> > +#include <linux/init.h> > +#include <linux/moduleparam.h> > + > +#include <linux/platform_device.h> > + > +#include <linux/ioport.h> > +#include <asm/io.h> > +#include <linux/interrupt.h> > + > +/* HZ */ > +#include <linux/param.h> > +/* jiffies, time_*() */ > +#include <linux/jiffies.h> > +/* schedule_timeout*() */ > +#include <linux/sched.h> > +/* spin_lock*() */ > +#include <linux/spinlock.h> > + > +/* snd_printk(), snd_printd() */ > +#include <sound/core.h> > +#include <sound/pcm.h> > +#include <sound/pcm_params.h> > +#include <sound/initval.h> > +#include <sound/ac97_codec.h> > + > + > +#define SND_ML403_AC97CR_DRIVER "ml403_ac97cr" > + > +MODULE_AUTHOR("Joachim Foerster <JOFT@xxxxxx>"); > +MODULE_DESCRIPTION("Xilinx ML403 AC97 Controller Reference"); > +MODULE_LICENSE("GPL"); > +MODULE_SUPPORTED_DEVICE("{{Xilinx,ML403 AC97 Controller Reference}}"); > +MODULE_VERSION("0.0.1-pre2"); This patch is targeted for mainline inclusion (which gives you the kernel version number). Do you really want to maintain a separate version number that needs to be update manually? I'd drop the MODULE_VERSION line. <snip> I'm not an ALSA expert, so I didn't review the rest of the code in detail (but I didn't see anything to comment on with a quick review). I'll try adding your patches to my tree this afternoon. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. grant.likely@xxxxxxxxxxxx (403) 399-0195 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
