At Thu, 9 Aug 2007 20:03:22 +0200, Krzysztof Helt wrote: > > On Thu, 09 Aug 2007 19:21:44 +0200 > Takashi Iwai <tiwai@xxxxxxx> wrote: > > > At Thu, 9 Aug 2007 19:06:43 +0200, > > Krzysztof Helt wrote: > > > > > > > obj-$(CONFIG_SND_AD1848) += snd-ad1848.o snd-ad1848-lib.o > > > > This line should contain only snd-ad1848.o. > > > ok. > > > > -obj-$(CONFIG_SND_OPTI92X_AD1848) += snd-ad1848-lib.o > > > +obj-$(CONFIG_SND_AD1848_LIB) += snd-ad1848-lib.o > > > > > > obj-m := $(sort $(obj-m)) > > > > Oh, this sort is also superfluous. > > > > There need similar cleanups in other isa/* directories. > > Care to create a patch including them? > > > > Should this be one patch for all isa libs or each one in the separate patch? It doesn't matter, but I think it's OK to put in a single patch. It won't be so big. thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel