At Thu, 9 Aug 2007 19:06:43 +0200, Krzysztof Helt wrote: > > From: Krzysztof Helt <krzysztof.h1@xxxxx> > > This patch uses the Kconfig parameter SND_AD1848_LIB instead > of mentioning each driver that requires the ad1848-lib separately > in the Makefile. > > Signed-off-by: Krzysztof Helt <krzysztof.h1@xxxxx> > --- > > diff -urp linux-2.6.23.old/sound/isa/ad1848/Makefile linux-2.6.23/sound/isa/ad1848/Makefile > --- linux-2.6.23.old/sound/isa/ad1848/Makefile 2007-08-04 22:12:08.000000000 +0200 > +++ linux-2.6.23/sound/isa/ad1848/Makefile 2007-08-08 18:53:20.000000000 +0200 > @@ -7,9 +7,7 @@ snd-ad1848-lib-objs := ad1848_lib.o > snd-ad1848-objs := ad1848.o > > # Toplevel Module Dependency > -obj-$(CONFIG_SND_CMI8330) += snd-ad1848-lib.o > -obj-$(CONFIG_SND_SGALAXY) += snd-ad1848-lib.o > obj-$(CONFIG_SND_AD1848) += snd-ad1848.o snd-ad1848-lib.o This line should contain only snd-ad1848.o. > -obj-$(CONFIG_SND_OPTI92X_AD1848) += snd-ad1848-lib.o > +obj-$(CONFIG_SND_AD1848_LIB) += snd-ad1848-lib.o > > obj-m := $(sort $(obj-m)) Oh, this sort is also superfluous. There need similar cleanups in other isa/* directories. Care to create a patch including them? thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel