Takashi Iwai wrote: > OK, now found another problem. The driver seems not built without > CONFIG_I2C. > > In file included from sound/soc/codecs/cs4270.c:1: > sound/soc/codecs/cs4270.c:694: error: ‘cs4270_set_dai_sysclk’ undeclared here (not in a function) > sound/soc/codecs/cs4270.c:695: error: ‘cs4270_set_dai_fmt’ undeclared here (not in a function) > > Shouldn't the driver be dependent on I2C? Well, technically no. It should work find without I2C, but I admit I never tried that. I'll provide a fix soon. > Also, > > #ifdef CONFIG_I2C > > isn't enough. It should be > > #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) I asked about that a while ago, and I never got an answer. Where does CONFIG_I2C_MODULE come from? I don't see it in any Kconfig or any header file. And if I2C can be a module, then why wouldn't CONFIG_I2C also be defined? -- Timur Tabi Linux Kernel Developer @ Freescale _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
