At Wed, 28 Feb 2007 18:29:47 +0100, Remy Bruno wrote: > > Hi, > > On Thursday 22 February at 16:37, Takashi Iwai wrote: > > > > > > Well, my (maybe wrong) guess is that we need a buffer for playback and a > > > buffer for capture, so the required size is twice the one-way size. > > > > The buffer allocated there is stream-specific. That is, it's the > > buffer for a single direction. *_preallocate_pages_for_all() will > > allocate the request buffer size for _each_ stream, thus it will end > > up with simply unnecessarily big memory allocation. > > OK, so I had indeed a wrong understanding, you can fix this. > > > > > Otherwise the patch looks pretty OK to me. Could you give a changelog > > and a sign-off for committing to ALSA HG tree? > > Changelog: > > hdspm - Support for Master mode of AES32 and recent MADI > > The current MADI driver was found not to completely work, at least on recent > MADI cards (rev 204), in particular at 96kHz. This patch solves this: > * Add support of DDS feature > * Channel map fixed > * Channel/rate rules fixed > * DMA allocation fixed (need to alloc for all channels and not only for the > used ones) > Full support for AES32 master mode was added: > * Add support of DDS feature > * Channel map fixed > * Channel/rate rules fixed > > Signed-off-by: Remy Bruno <remy.bruno@xxxxxxxxxxx> Thanks, now it's on ALSA HG tree. > Please remember that this patch should be tested on "old" MADI cards, as I'm > not sure if it will work on them. Don't worry, it's not in the stable tree. Let's see whether it breaks :) Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
