At Tue, 20 Feb 2007 18:04:18 +0100, Remy Bruno wrote: > > Here is the new patch. Comments below: > > On Wednesday 14 February at 16:00, Takashi Iwai wrote: > > > > @@ -4184,7 +4325,8 @@ static int __devinit snd_hdspm_prealloca > > > pcm = hdspm->pcm; > > > > > > /* wanted = HDSPM_DMA_AREA_BYTES + 4096;*/ /* dont know why, but it works */ > > > - wanted = HDSPM_DMA_AREA_BYTES; > > > + /* Two times, for both input and output */ > > > + wanted = 2 * HDSPM_DMA_AREA_BYTES; > > > > This shouldn't be necessary. Since the buffer size for each stream is > > fixed, it's not necessarily bigger than that. > > Well, my (maybe wrong) guess is that we need a buffer for playback and a > buffer for capture, so the required size is twice the one-way size. The buffer allocated there is stream-specific. That is, it's the buffer for a single direction. *_preallocate_pages_for_all() will allocate the request buffer size for _each_ stream, thus it will end up with simply unnecessarily big memory allocation. Otherwise the patch looks pretty OK to me. Could you give a changelog and a sign-off for committing to ALSA HG tree? Thanks, Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
