At Fri, 23 Feb 2007 16:07:18 -0800, John Utz wrote: > > This patch simplifies the alsa-kernel discovery logic and provides better error > reporting in the event of not finding $ALSAKERNELDIR/last.c > > Signed off by John L. Utz III john.utz@xxxxxxxxxxxx > (tho why my uneducated opinion matters is beyond me) > > > diff -r 62c0e3989241 hgcompile > --- a/hgcompile Thu Feb 22 13:24:18 2007 +0100 > +++ b/hgcompile Fri Feb 23 15:54:24 2007 -0800 > @@ -27,17 +27,26 @@ fi > # cd .. > #fi > > -# check for alsa-kernel directory > -if [ -d alsa-kernel -a -f alsa-kernel/last.c ]; then > - ALSAKERNELDIR="alsa-kernel" > -else > - test -z $ALSAKERNELDIR && ALSAKERNELDIR=../alsa-kernel > - if [ ! -d $ALSAKERNELDIR -o ! -f $ALSAKERNELDIR/last.c ]; then > - echo "No alsa-kernel is found." > - echo "Please specify the correct location via ALSAKERNELDIR environment variable." > +# check for caller set alsa-kernel directory, if empty set to default > + > +if [ -z $ALSAKERNELDIR ]; then > + ALSAKERNELDIR=../alsa-kernel > +fi > + > +ALSACHKFILE=$ALSAKERNELDIR/last.c > + > +echo "ALSA Kernel Directory is: $ALSAKERNELDIR, checking for checkfile: $ALSACHKFILE" ./alsa-kernel should be in the higher priority than ../alsa-kernel. Please add the check as found in the original version. Otherwise the patch looks good. Thanks, Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
