At Mon, 19 Feb 2007 14:49:54 -0500, Nicholas Kain wrote: > > On 2/19/07, Takashi Iwai <tiwai@xxxxxxx> wrote: > > IMO, we should _add_ libavcodec resampler plugin instead of replacing > > the libsamplerate one. From the license POV, libavcodec is fairly > > grey, and it's very unlikely bundled in most of linux distributions. > > > > So, could you change your patch to add a new subdirectory and plugin? > > We have already HAVE_AVCODEC conditional in configure script, hence > > the addition would be pretty simple. > > Sure. I've attached a patch that places the plugin in a rate-lavc > subdirectory. It also provides a minimal .txt document for the plugin as > well. > > I've also fixed a few minor bugs in the previous patch that were > preventing optimal quality in conversions, so if anyone has tested the > patch I sent earlier, it might be worth trying again. Thanks. The code looks fine, but I found that you still keep GPL in rate_lavcrate.c instead of LGPL. Is it intentional? Also, please give a changelog description for committing to HG tree, too. Takashi ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
