Re: [PATCH] Replace libsamplerate resampler with libavcodec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Mon, 19 Feb 2007 01:14:11 -0500,
Nicholas Kain wrote:
> 
> libsamplerate does a nice job of upsampling audio while retaining quality, but
> is rather inefficient and is GPL-licensed.  libavcodec includes a resampler of
> equivalent quality that is about an order of magnitude faster in my tests.
> 
> ALSA is already using libavcodec for its a52 plugin, but it is important to
> note that the a52 code in libavcodec is one of a few parts in lavc that is
> licensed under the GPL.  The resampling code is LGPL licensed, so it's
> available under much more flexible terms.
> 
> I've written a patch that replaces the use of libsamplerate with libavcodec's
> resampler.  It is currently a drop-in replacement that uses the exact same
> interfaces and dynamically links to libavcodec.  It is easily possible to pull
> the LGPL resampling code out of libavcodec and include it directly with the
> plugin if that is desirable -- it would not require invasive modifications --
> but I have not done so yet.

IMO, we should _add_ libavcodec resampler plugin instead of replacing
the libsamplerate one.  From the license POV, libavcodec is fairly
grey, and it's very unlikely bundled in most of linux distributions.

So, could you change your patch to add a new subdirectory and plugin?
We have already HAVE_AVCODEC conditional in configure script, hence
the addition would be pretty simple.


Thanks,

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux