Remove AC97 POP control for STAC9708/11

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Summary: Remove AC97 POP control for STAC9708/11

	The STAC9708/11 AC97 codecs implement the PCM Out Path & Mute bit in
the General Purpose register (0x20:F), even though they don't implement
the actual function in the mixer.

	Since the alsa tests for the function by toggling the bit and reading
it back to see if it changed, it mistakenly creates a useless control.

	This patch explicitly removes the control when the codec is an
STAC9708/11.

	I put the check in patch_sigmatel_stac9708_specific(), because I have
an SBLive with this chip on it. I don't know if the STAC9758 or other
codecs also behave this way. If they do, then this check could maybe go
in patch_sigmatel_stac97xx_specific(), or some other more general
function.

Signed-off-by: James C Georgas <jgeorgas@xxxxxxxxxx>

--- a/pci/ac97/ac97_patch.c     Thu Dec  7 15:04:27 2006 +0100
+++ b/pci/ac97/ac97_patch.c     Sat Dec  9 02:43:56 2006 -0500
@@ -940,6 +940,9 @@ static int patch_sigmatel_stac9708_speci
 static int patch_sigmatel_stac9708_specific(struct snd_ac97 *ac97)
 {
        int err;
+
+       // the register bit is writable, but the function is not implemented:
+       snd_ac97_remove_ctl(ac97, "PCM Out Path & Mute", NULL);

        snd_ac97_rename_vol_ctl(ac97, "Headphone Playback", "Sigmatel Surround Playback");
        if ((err = patch_build_controls(ac97, &snd_ac97_stac9708_bias_control, 1)) < 0)



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux