Re: [PATCH] Enable stereo line input for TAS codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Sun, 29 Oct 2006 15:10:27 +1100,
Paul Mackerras wrote:
> 
> Despite what the data sheet says in one place, to get stereo input
> from input A (line in), we have to clear the "input B monaural" bit in
> the ACR.
> 
> Signed-off-by: Paul Mackerras <paulus@xxxxxxxxx>

Applied to ALSA tree now.
Thanks.


Takashi


> ---
> 
> diff --git a/sound/aoa/codecs/snd-aoa-codec-tas.c b/sound/aoa/codecs/snd-aoa-codec-tas.c
> index 2ef55a1..9de8485 100644
> --- a/sound/aoa/codecs/snd-aoa-codec-tas.c
> +++ b/sound/aoa/codecs/snd-aoa-codec-tas.c
> @@ -514,9 +514,15 @@ static int tas_snd_capture_source_put(st
>  	mutex_lock(&tas->mtx);
>  	oldacr = tas->acr;
>  
> -	tas->acr &= ~TAS_ACR_INPUT_B;
> +	/*
> +	 * Despite what the data sheet says in one place, the
> +	 * TAS_ACR_B_MONAUREAL bit forces mono output even when
> +	 * input A (line in) is selected.
> +	 */
> +	tas->acr &= ~(TAS_ACR_INPUT_B | TAS_ACR_B_MONAUREAL);
>  	if (ucontrol->value.enumerated.item[0])
> -		tas->acr |= TAS_ACR_INPUT_B;
> +		tas->acr |= TAS_ACR_INPUT_B | TAS_ACR_B_MONAUREAL |
> +		      TAS_ACR_B_MON_SEL_RIGHT;
>  	if (oldacr == tas->acr) {
>  		mutex_unlock(&tas->mtx);
>  		return 0;
> @@ -686,8 +692,7 @@ static int tas_reset_init(struct tas *ta
>  	if (tas_write_reg(tas, TAS_REG_MCS, 1, &tmp))
>  		goto outerr;
>  
> -	tas->acr |= TAS_ACR_ANALOG_PDOWN | TAS_ACR_B_MONAUREAL |
> -		TAS_ACR_B_MON_SEL_RIGHT;
> +	tas->acr |= TAS_ACR_ANALOG_PDOWN;
>  	if (tas_write_reg(tas, TAS_REG_ACR, 1, &tas->acr))
>  		goto outerr;
>  
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
> 

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux