On Thu, 2006-10-12 at 14:18 +0200, Takashi Iwai wrote:
> At Thu, 12 Oct 2006 12:58:01 +0100,
> Liam Girdwood wrote:
> >
> > On Thu, 2006-10-12 at 12:54 +0200, Takashi Iwai wrote:
> > > At Thu, 12 Oct 2006 11:27:19 +0100,
> > > Liam Girdwood wrote:
> > > >
> > > > On Tue, 2006-10-10 at 19:14 +0200, Takashi Iwai wrote:
> > > > > At Tue, 10 Oct 2006 17:19:36 +0100,
> > > > > Liam Girdwood wrote:
> > > > > > +/* may need to expand this */
> > > > > > +static struct snd_soc_dai_mode pxa2xx_ac97_modes[] = {
> > > > > > + {0, 0, SNDRV_PCM_FMTBIT_S16_LE, AC97_RATES},
> > > > >
> > > > > Better to use ".field = value" initialization.
> > > >
> > > > IMHO, this is a better style for the DAI capabilities field because it
> > > > can grow quite large depending on the DAI.
> > >
> > > On the contrary, it can reduce the size.
> > > With .field=value style, you can ommit the above 0 initialization, for
> > > example. Ommitted fields are initialized to 0 as default.
> > >
> > > And, the readability is of course much better with .field=value style
> > > :)
> >
> > Np, Fixed.
>
> Thanks. Could you fix at91rm9200-i2s.c, too?
Ok, I'll also have to make changes to pxa2xx-i2s.c, wm8731.c and
wm8750.c.
Liam
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
