At Tue, 10 Oct 2006 17:19:36 +0100,
Liam Girdwood wrote:
> +/* may need to expand this */
> +static struct snd_soc_dai_mode pxa2xx_ac97_modes[] = {
> + {0, 0, SNDRV_PCM_FMTBIT_S16_LE, AC97_RATES},
Better to use ".field = value" initialization.
> +static irqreturn_t pxa2xx_ac97_irq(int irq, void *dev_id,
> + struct pt_regs *regs)
Note that in the latest kernel code, the last struct pt_regs pointer
is removed from irq handler. I already updated ALSA HG tree
accordingly.
> +static int pxa2xx_ac97_probe(struct platform_device *pdev)
> +{
> + int ret;
> +
> + ret = request_irq(IRQ_AC97, pxa2xx_ac97_irq, 0, "AC97", NULL);
Don't you need IRQF_DISABLED (former SA_INTERRUPT)?
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
