At Tue, 10 Oct 2006 17:19:45 +0100,
Liam Girdwood wrote:
>
> +static int corgi_jack_func = 0;
> +static int corgi_spk_func = 0;
'= 0' can be omitted.
> +static int corgi_set_jack(struct snd_kcontrol *kcontrol,
> + struct snd_ctl_elem_value *ucontrol)
> +{
> + struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
> + corgi_jack_func = ucontrol->value.integer.value[0];
> + corgi_ext_control(codec);
> + return 0;
> +}
The put callback should return 1 if the value is changed.
> +unsigned int corgi_config_sysclk(struct snd_soc_pcm_runtime *rtd,
> + struct snd_soc_clock_info *info)
> +{
Missing static?
> + if (info->bclk_master & SND_SOC_DAIFMT_CBS_CFS) {
> + /* pxa2xx is i2s master */
> + switch(info->rate) {
> + case 44100:
> + case 88200:
cases are normally in the same indent level as switch().
Also, put a space between switch and (.
Takashi
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
