On Thu, 5 Oct 2006, Takashi Iwai wrote: > At Thu, 5 Oct 2006 13:11:51 +0200 (CEST), > Jaroslav Kysela wrote: > > > > On Thu, 5 Oct 2006, Takashi Iwai wrote: > > > > > At Thu, 05 Oct 2006 12:10:45 +0200, > > > Thierry Vignaud wrote: > > > > > > > > Takashi Iwai <tiwai@xxxxxxx> writes: > > > > > > > > > The rollback was triggered. The repository was rolled back to > > > > > the changeset number bellow. All patches on top of this changeset > > > > > were lost. > > > > > > > > > > changeset: 4582:9233e1d82ed045609e1fb76acf00696393589031 > > > > > tag: tip > > > > > user: perex > > > > > date: Thu Oct 05 09:30:36 2006 +0200 > > > > > files: pci/ac97/ac97_patch.c > > > > > description: > > > > > ac97_codec (ALC655): add EAPD hack for MSI L725 laptop > > > > > New PCI ID described and tested Spectr <spectr@xxxxxxxxx> . > > > > > > > > I think that: > > > > - the reason of the rollback should be visible and the mail (aka the > > > > rollback commit changelog) > > > > - the rollback commit changelog) should be in the suject line rather > > > > than the changelog of the commit we reverse to, since it's more > > > > important > > > > > > The rollback has no log for itself... > > > > Yes, we have no additional information. Anyway, all rollbacks means "wrong > > patch". In this case, I figured immediately after commit that mpu401 patch > > does not make any sense and it was problem in the driver core code in > > mainstream (I already proposed correct patch on LKML). > > Well, then in this case, something went wrong in the retrieval of the > target changeset. It should have shown mpu401-stuff instead of this > AC97 change. Yes, that would be probably the best solution, but the problem is that I've not found a way to determine which changesets will roll back (note that the whole last push will be lost, not only last changeset). Also, hg does not call any hook on rollback. I've put a bug number 384 to hg tracker: http://www.selenic.com/mercurial/bts/issue384 Jaroslav ----- Jaroslav Kysela <perex@xxxxxxx> Linux Kernel Sound Maintainer ALSA Project, SUSE Labs ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
