[PATCH] Reset file->f_op in snd_card_file_remove()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

This patch helps prevent an oops on 2.6.18-rt3,
when my usb usx2y soundcard disconnects.
Physically disconnects or "rmmod uhci_hc" both oops 1in7.

With this patch still no oops after > 1000 disconnects.

Please apply/comment.

      thanks,
      Karsten

===

Reset file->f_op in snd_card_file_remove()

When passing here in response to an usb disconnect,
file->f_op has been replaced with a kmalloc()ed version,
that would only allow releases.

It will be free()ed later on in snd_card_free().
Here it happened sometimes, that the free()ed, not NULLed file->f_op
caused an oops in module_put() called by fops_put() still later on.

Signed-off-by: Karsten Wiese <annabellesgarden@xxxxxxxx>



--- rt3/sound/core/init.c	2006-09-23 20:03:18.000000000 +0200
+++ rt3-kw/sound/core/init.c	2006-09-27 20:44:54.000000000 +0200
@@ -722,6 +722,7 @@ int snd_card_file_remove(struct snd_card
 	mfile = card->files;
 	while (mfile) {
 		if (mfile->file == file) {
+			file->f_op = NULL;
 			if (pfile)
 				pfile->next = mfile->next;
 			else

	

	
		
___________________________________________________________ 
Der frühe Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: http://mail.yahoo.de


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux