At Thu, 7 Sep 2006 20:47:00 -0400, Mike Frysinger wrote: > > some architectures, like Blackfin, have a prefix added to all symbols (in our > case it's historical baggage) > > while normally packages shouldnt care, when code starts mixing assembler with > C (like symbol versioning), you need to dip down into the inner details. > find attached a patch which queries gcc for the prefix (all gcc toolchains > have a builtin define of __USER_LABEL_PREFIX__) and then automatically has > asm() constructs utilize this > > since most targets define __USER_LABEL_PREFIX__ to nothing, hopefully this > shouldnt cause any problems :) So, the current build doesn't work for such architectures with __USER_LABEL_PREFIX__? The change you did basically looks OK to me... > diff -r 46221e609f45 include/alsa-symbols.h > --- a/include/alsa-symbols.h Wed Sep 06 14:39:01 2006 +0200 > +++ b/include/alsa-symbols.h Thu Sep 07 20:45:45 2006 -0400 > @@ -22,6 +22,14 @@ > #ifndef __ALSA_SYMBOLS_H > #define __ALSA_SYMBOLS_H > > +#ifdef __USER_LABEL_PREFIX__ > +# define __SYMBOL_PREFIX __USER_LABEL_PREFIX__ > +#else > +# define __SYMBOL_PREFIX > +#endif > + > +#include "local.h" This inclusion looks superfluous. This file itself is included from local.h. Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
