At Wed, 23 Aug 2006 11:45:45 +0100, Jochen Voss wrote: > > Hi Takashi, > > On Wed, Aug 23, 2006 at 11:45:00AM +0200, Takashi Iwai wrote: > > > #define AK_GET_CHIP(val) (((val) >> 8) & 0xff) > > > #define AK_GET_ADDR(val) ((val) & 0xff) > > > #define AK_GET_SHIFT(val) (((val) >> 16) & 0x7f) > > > > Shouldn't this be (((val) >> 16) & 0x3f) to exclude bit 22? > > > > > +#define AK_GET_NEEDSMSB(val) (((val) >> 22) & 1) > > Yes, I think you are right. Currently there is no problem, since > shift is never used simultaneously with needsmsb, but this should be > fixed anyway. I will check all users of shift to see whether they are > all fine with a 6 bit value. If so, I will try to prepare another > patch until tomorrow or so. It's a shift bit number, so 3 bit should be enough for a byte data. I'll fix it and queue to my local tree. thanks, Takashi ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
