Re: [PATCH] fix volume control for the AK4358 DAC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Tue, 22 Aug 2006 21:00:10 +0100,
Jochen Voss wrote:
> 
> Fix volume control for the AK4358 DAC.
> 
> The attenuation control registers of the AK4358 use only 7bit for the
> volume, the msb is used to enable attenuation output.  Without this
> patch there are 256 volume levels the lower 128 of which are mute.
> 
> Signed-off-by: Jochen Voss <voss@xxxxxxxxxx>
> 
> 
> diff -ur alsa-driver-1.0.12rc3.orig/alsa-kernel/i2c/other/ak4xxx-adda.c alsa-driver-1.0.12rc3/alsa-kernel/i2c/other/ak4xxx-adda.c
> --- alsa-driver-1.0.12rc3.orig/alsa-kernel/i2c/other/ak4xxx-adda.c	2006-08-14 11:55:24.000000000 +0100
> +++ alsa-driver-1.0.12rc3/alsa-kernel/i2c/other/ak4xxx-adda.c	2006-08-22 20:46:42.000000000 +0100
> @@ -285,10 +285,12 @@
>  #define AK_GET_CHIP(val)		(((val) >> 8) & 0xff)
>  #define AK_GET_ADDR(val)		((val) & 0xff)
>  #define AK_GET_SHIFT(val)		(((val) >> 16) & 0x7f)

Shouldn't this be (((val) >> 16) & 0x3f) to exclude bit 22?

> +#define AK_GET_NEEDSMSB(val)		(((val) >> 22) & 1)


Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux