Re: [PATCH] Au1xxx sound registration and power management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 20 Jul 2006 09:37:00 +0200,
Rodolfo Giometti wrote:
> 
> Hello,
> 
> here a patch to support device registration and power management for
> the au1xxx ALSA driver.

Thanks for the patch.

Would you mind to split this to several patches?  Namely,
- addition of new resources in arch/mips/*
- move to platform_device
- addition of PM

(Since we have a separate ALSA-kernel tree from linux tree, it's
easier for us to keep the changes in arch/ and sound/ separately.)

I'm afraid that snd_au1000_free() still releases the ac97 resource,
which looks now like a static one.  Is it intended behavior?

Also, au1000_ac97_config could be better in struct snd_au1000 rather
than a static variable.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux