At Sun, 02 Jul 2006 18:45:59 -0400, Lee Revell wrote: > > Can someone take a quick look at: > > https://bugtrack.alsa-project.org/alsa-bug/view.php?id=952 > > There is a nice screenshot of the kernel panic. The bug has been > verified with ALSA 1.0.12-rc1. > > It seems to crash while taking a spinlock in snd_timer_interrupt when > called from rtc_interrupt - maybe the changes to the ALSA RTC timer a > few months ago are involved? Does the patch below fix? Takashi diff -r 0dc0bac494b6 core/timer.c --- a/core/timer.c Mon Jul 03 16:38:28 2006 +0200 +++ b/core/timer.c Mon Jul 03 17:56:22 2006 +0200 @@ -628,8 +628,9 @@ static void snd_timer_tasklet(unsigned l struct snd_timer_instance *ti; struct list_head *p; unsigned long resolution, ticks; - - spin_lock(&timer->lock); + unsigned long flags; + + spin_lock_irqsave(&timer->lock, flags); /* now process all callbacks */ while (!list_empty(&timer->sack_list_head)) { p = timer->sack_list_head.next; /* get first item */ @@ -649,7 +650,7 @@ static void snd_timer_tasklet(unsigned l spin_lock(&timer->lock); ti->flags &= ~SNDRV_TIMER_IFLG_CALLBACK; } - spin_unlock(&timer->lock); + spin_unlock_irqrestore(&timer->lock, flags); } /* Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel
