On Thu, Jun 29, 2006 at 12:57:49PM +0200, Takashi Iwai wrote: > At Thu, 29 Jun 2006 11:49:44 +0200, > Adrian Bunk wrote: > > > > CONFIG_SND_FM801=y, CONFIG_SND_FM801_TEA575X=m resulted in the following > > compile error: > > > > <-- snip --> > > > > ... > > LD vmlinux > > sound/built-in.o: In function `snd_fm801_free': > > fm801.c:(.text+0x3c15b): undefined reference to `snd_tea575x_exit' > > sound/built-in.o: In function `snd_card_fm801_probe': > > fm801.c:(.text+0x3cfde): undefined reference to `snd_tea575x_init' > > make: *** [vmlinux] Error 1 > > > > <-- snip --> > > > > This patch fixes kernel Bugzilla #6458. > > > > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx> > > Could it be a simplier one like below? Your patch would in the case of SND_FM801=m: - build snd-tea575x-tuner.o statically into the kernel - set VIDEO_DEV=y > Takashi > > > diff -r cd7256009b28 sound/pci/Kconfig > --- a/sound/pci/Kconfig Wed Jun 28 16:39:36 2006 +0200 > +++ b/sound/pci/Kconfig Thu Jun 29 12:54:08 2006 +0200 > @@ -461,16 +461,13 @@ config SND_FM801 > will be called snd-fm801. > > config SND_FM801_TEA575X > - tristate "ForteMedia FM801 + TEA5757 tuner" > + bool "TEA5757 tuner support on ForteMedia FM801" > depends on SND_FM801 > select VIDEO_DEV > help > Say Y here to include support for soundcards based on the ForteMedia > FM801 chip with a TEA5757 tuner connected to GPIO1-3 pins (Media > Forte SF256-PCS-02). > - > - To compile this driver as a module, choose M here: the module > - will be called snd-fm801-tea575x. > > config SND_HDA_INTEL > tristate "Intel HD Audio" > diff -r cd7256009b28 sound/pci/fm801.c > --- a/sound/pci/fm801.c Wed Jun 28 16:39:36 2006 +0200 > +++ b/sound/pci/fm801.c Thu Jun 29 12:54:08 2006 +0200 > @@ -35,7 +35,7 @@ > > #include <asm/io.h> > > -#if (defined(CONFIG_SND_FM801_TEA575X) || defined(CONFIG_SND_FM801_TEA575X_MODULE)) && (defined(CONFIG_VIDEO_DEV) || defined(CONFIG_VIDEO_DEV_MODULE)) > +#ifdef CONFIG_SND_FM801_TEA575X > #include <sound/tea575x-tuner.h> > #define TEA575X_RADIO 1 > #endif cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-devel