At Thu, 29 Jun 2006 09:52:19 +0200,
Henrik Kretzschmar wrote:
>
> Thanks for applying the patch.
>
> I played a little bit with the driver and everytime I got ENODEV from modprobe.
> Later I found out that the module_init() function returns ENODEV when
> pci_register_driver() return an error or zero(huh!(which is the retval for sucess)).
>
> After fixing that in my sourves I get a EPERM from
> pci_register_driver(), but the driver structure looks well to me.
The patch below should fix. Already committed to HG repo now.
Takashi
# HG changeset patch
# User tiwai
# Node ID d736c6c1702ffc9799ec8057926b7cf6d49866b9
# Parent 7f0121f426317caa3c6da31c0ec350004f61342d
Fix initialization of pdplus driver
Don't include '/' in the name for pci_driver, which is not allowed
as the sysfs entry.
pci_register_driver() returns 0 if successful. Just return as is.
diff -r 7f0121f42631 -r d736c6c1702f pci/pdplus/pdplus.c
--- a/pci/pdplus/pdplus.c Wed Jun 28 16:36:24 2006 +0200
+++ b/pci/pdplus/pdplus.c Thu Jun 29 13:05:04 2006 +0200
@@ -265,7 +265,7 @@
/* ********************************************************************** */
-#define VENDOR_NAME "SekD/Marian"
+#define VENDOR_NAME "SekD-Marian"
/* Sek'd builds the card, but the vendor ID is Marian's. So I decided
* to use Marian as the vendor name. Correct me if I'm wrong. */
@@ -6192,18 +6192,13 @@ static struct pci_driver driver = {
static int __init alsa_card_pdplus_init(void)
{
- ENTER;
-
/*
* Check that our macros work. */
snd_assert (PDPLUS_HW_REG_WR_INITIAL_1 == 0x22, return -ENXIO);
snd_assert (PDPLUS_HW_REG_WR_INITIAL_2 == 0x32, return -ENXIO);
printk (PDPLUS_KERN_INFO "version " PDPLUS_VERSION "\n");
- if (pci_register_driver (&driver) <= 0)
- LEAVE (-ENODEV);
-
- LEAVE (0);
+ return pci_register_driver (&driver);
}
static void __exit alsa_card_pdplus_exit(void)
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-devel
