On 3/24/22 11:41, Sam James wrote: > > >> On 24 Mar 2022, at 14:42, Bob Friesenhahn >> <bfriesen@xxxxxxxxxxxxxxxxxxx> wrote: >> >> On Thu, 24 Mar 2022, Evgeny Grin wrote: >>> >>> It's not uncommon to use CFLAGS for macros or for '-I' flags. I >>> think it's easy to imagine other conflicting situation where the >>> order of used flags is significant. >> >> It may not be uncommon, but it is a usage bug to use CFLAGS for >> pre-processor options. Such usages should be corrected. >> >> Becides cases where the pre-processor may be used directly (not >> sure if there are any), it should be considered that CPPFLAGS works >> for both the C and C++ compilers but CFLAGS is only for the C >> compiler. >> >>> Usage of CPPFLAGS before CFLAGS looks logical for me, I think >>> autoconf should be fixed. >> >> It does feel more logical. >> > > Agreed on both counts & with the original post. We handle stuff like > this quite often downstream and would be glad to see this. In glibc it's historical to list CFLAGS before CPPFLAGS, but I can't come up with example where the order matters. I agree that making it consistent always helps. -- Cheers, Carlos.
