Re: [bug report] autoheader still creates .in file if no AC_CONFIG_HEADERS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kelley Cook wrote:
If you run autoheader 2.59b on a configure.ac without a AC_CONFIG_HEADERS, it will properly inform you

error: AC_CONFIG_HEADERS not found in configure.ac

Nevertheless the perl script continues which appends .in to nothing thereby creating the hidden file ".in" and procedes all outputs all the defines into it.

Two easy solutions would be to either abort after the error or to set a default for $config.h |= "config.h" right after the error message.

There are likely other solutions to this bug.

I didn't mention the spare ".in" files will show up whenever you use autoreconf on a directory not using autoheader.


Anyway here is the patch for the first proposed solution.

KC
2004-12-12  Kelley Cook  <kcook@xxxxxxxxxxx>

	* bin/autoheader.in: Exit if no AC_CONFIG_HEADERS was found.

Index: autoheader.in
===================================================================
RCS file: /cvsroot/autoconf/autoconf/bin/autoheader.in,v
retrieving revision 1.140
diff -p -u -d -r1.140 autoheader.in
--- autoheader.in	20 Aug 2004 06:17:21 -0000	1.140
+++ autoheader.in	13 Dec 2004 02:14:41 -0000
@@ -182,8 +182,11 @@ local (%verbatim, %symbol);
 debug "$me: \`do'ing $tmp/traces.pl:\n" . `sed 's/^/| /' $tmp/traces.pl`;
 do "$tmp/traces.pl";
 warn "couldn't parse $tmp/traces.pl: $@" if $@;
-error "error: AC_CONFIG_HEADERS not found in $ARGV[0]"
-  unless $config_h;
+unless ($config_h)
+  {
+    error "error: AC_CONFIG_HEADERS not found in $ARGV[0]";
+    exit 1;
+  }
 
 # We template only the first CONFIG_HEADER.
 $config_h =~ s/ .*//;
_______________________________________________
Autoconf mailing list
Autoconf@xxxxxxx
http://lists.gnu.org/mailman/listinfo/autoconf

[Index of Archives]     [GCC Help]     [Kernel Discussion]     [RPM Discussion]     [Red Hat Development]     [Yosemite News]     [Linux USB]     [Samba]

  Powered by Linux