[Crash-utility] Re: [PATCH] get vmalloc start address from vmcoreinfo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



LGTM

Acked-by: Tao Liu <ltao@xxxxxxxxxx>

On Mon, Mar 11, 2024 at 5:13 PM Aditya Gupta <adityag@xxxxxxxxxxxxx> wrote:
>
>
> On 11/03/24 10:53, Hari Bathini wrote:
> >
> >
> > On 01/03/24 12:32 pm, Aditya Gupta wrote:
> >> Below error is noticed when running crash on vmcore collected from a
> >> linux-next
> >> kernel crash (linux-next tag next-20240121):
> >>
> >>      # crash /boot/vmlinuz-6.8.0-rc5-next-20240221 ./vmcore
> >>      ……
> >>      ……
> >>      For help, type “help”.
> >>      Type "apropos word" to search for commands related to "word"...
> >>
> >>      crash: page excluded: kernel virtual address: c00000000219a2c0
> >> type: “vmlist"
> >>
> >> This occured since getting the vmalloc area base address doesn't work in
> >> crash now, due to 'vmap_area_list' being removed in the linux kernel
> >> with
> >> below commit (in linux-next tree):
> >>
> >>      commit 378eb24a0658dd922b29524e0ce35c6c43f56cba
> >>           mm/vmalloc: remove vmap_area_list
> >>
> >> As an alternative, the commit introduced 'VMALLOC_START' in
> >> vmcoreinfo to
> >> get base address of vmalloc area, use it to return vmallow start address
> >> instead of depending on vmap_area_list and vmlist
> >>
> >
> > LGTM.
> >
> > Acked-by: Hari Bathini <hbathini@xxxxxxxxxxxxx>
> >
> Thanks for the ack, hari.
>
> - Aditya Gupta
> --
> Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
> https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
> Contribution Guidelines: https://github.com/crash-utility/crash/wiki
--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux