[Crash-utility] Re: [PATCH v3 00/10] add LoongArch64 platform support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/4/24 11:46, Ming Wang wrote:

Hi, Lianbo

On 1/3/24 17:57, Lianbo Jiang wrote:
Hi, Ming

Thank you for the update.
Ming Wang (10):
    Add LoongArch64 framework code support
    LoongArch64: Make the crash tool successfully enter the crash command
      line
    LoongArch64: Add 'pte' command support
    LoongArch64: Add 'mach' command support
    LoongArch64: Add 'bt' command support
    LoongArch64: Add 'help -m/M' command support
    LoongArch64: Add 'help -r' command support
    LoongArch64: Add 'irq' command support
    LoongArch64: Add "--kaslr" command line option support
    LoongArch64: Add LoongArch64 architecture support information

   Makefile            |     7 +-
   README              |     4 +-
   configure.c         |    43 +-
   crash.8             |     2 +-
   defs.h              |   164 +-
   diskdump.c          |    24 +-
   gdb-10.2.patch      | 12822 +++++++++++++++++++++++++++++++++++++++++-
This is really a big change for the gdb, there are 12822 lines of code. :-) Is it possible to support the LoongArch64 feature if a very smaller change is made in the gdb patch? For example: trying to remove redundant(unnecessary) changes, as I mentioned in the V1.

Or is it hard to implement this feature based on the gdb-10.2? Looks like all code changes are backported from the latest gdb?
Yes, it is. The upstream loongarch gdb does not work until 13.2.
Got it.
I also tried to build a very small compact version myself,but it
didn't work.I'm still looking for the reason.

Thanks for trying, Ming.

This is ideal situation if the gdb patch is very small, it will be easy to maintain and debug.


Perhaps waiting for crash to rebase embedded gdb to a later version
is the best way to solve this problem.At present, I have also seen

You are right, there are fewer code changes based on the rebase version.

I would tend to wait for the rebase(if it is not urgent for you), but recently we have not planned to update the embedded gdb in crash-utility.

Anyway, maybe Kazu has some comments on it(BTW:He is on vacation).


Thanks.

Lianbo

someone submit a preview version of 13.2[1].

[1]: https://github.com/liutgnu/crash-preview

I can do some testing work based on this preview version first.


Thanks,

Ming

--
Crash-utility mailing list -- devel@xxxxxxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxxxxxxxxxxxx
https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
Contribution Guidelines: https://github.com/crash-utility/crash/wiki




[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux