On 2023/03/15 20:18, Juergen Gross wrote:
> When trying to look into a vmcore in Xen mode which was obtained from
> a machine running Xen 4.16, I realized that crash wasn't able to handle
> that.
>
> Looking into the issue I found that crash is lacking several adaptions
> to newer Xen versions (at least 4.13 onwards).
>
> There might be more missing, but it is now at least possible to do
> _some_ debugging.
>
> Changes in V2:
> - addressed comments
Thank you for the v2.
Another warning is observed but this can be fixed when applying.
xen_hyper.c: In function ‘xen_hyper_x86_pcpu_init’:
xen_hyper.c:375:23: warning: ‘stack_base’ may be used uninitialized in this function [-Wmaybe-uninitialized]
readmem(stack_base + sizeof(ulong) * cpuid, KVADDR, &sp,
~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
So for the series,
Acked-by: Kazuhito Hagio <k-hagio-ab@xxxxxxx>
Thanks,
Kazu
>
> Juergen Gross (3):
> xen: fix stacksize
> xen: get stack address via stack_base array if available
> xen: adjust to new scheduler structures
>
> x86_64.c | 2 +-
> xen_hyper.c | 119 +++++++++++++++++++++++++---------------
> xen_hyper_defs.h | 4 +-
> xen_hyper_dump_tables.c | 4 ++
> 4 files changed, 83 insertions(+), 46 deletions(-)
>
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://listman.redhat.com/mailman/listinfo/crash-utility
Contribution Guidelines: https://github.com/crash-utility/crash/wiki
