On Tue, Feb 14, 2023 at 9:43 AM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx> wrote:
Hi Georges, Lianbo,
On 2023/02/09 13:55, lijiang wrote:
> On Wed, Feb 8, 2023 at 9:08 PM Aureau, Georges (Kernel Tools ERT) <
> georges.aureau@xxxxxxx> wrote:
>
>>
>>> It could be good to check the return value of gdb_pass_through(). For
>> example:
>>
>> This would not bring much value, if disasm fails, tmpfile would not have
>> much to process anyway.
>>
>>
> It's true. But if the gdb_pass_through() call fails, it will still
> execute the remaining code. Seems that is not expected behavior.
ok I've added it and a commit log from Georges' description,
is the attached patch fine?
Looks good. For the patch: Ack.
Thanks,
Kazu
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
