On Wed, Feb 8, 2023 at 9:08 PM Aureau, Georges (Kernel Tools ERT) <georges.aureau@xxxxxxx> wrote:
> It could be good to check the return value of gdb_pass_through(). For example:
This would not bring much value, if disasm fails, tmpfile would not have much to process anyway.
It's true. But if the gdb_pass_through() call fails, it will still execute the remaining code. Seems that is not expected behavior.
+ if (STREQ(arglist[2], "bswap")) {
+ found = TRUE;
+ //break;
> Here, the above break is still needed.
Indeed, this was a leftover when printing full tmpfile content.
See latest patch proposed in thread "[PATCH] kmem -s/-S not working properly on RHEL8.6/8.7"
Thank you for the update, Georges.
Lianbo
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://listman.redhat.com/mailman/listinfo/crash-utility Contribution Guidelines: https://github.com/crash-utility/crash/wiki
