Re: Fwd: [PATCH 0/3] trace.so: Make trace dump -t work again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> 
> 
> ----- Original Message -----
> > 
> > On 3/19/19 6:48 PM, Dave Anderson wrote:
> > >>>>> The problem happens only with module symbols, not with kallsyms.
> > >>>>>
> > >>>>> crash> sym -M
> > >>>>> c008000007810000 MODULE START: crc32c_vpmsum
> > >>>>> c008000007810000 (^R) __crc32c_vpmsum
> > >>>>> c008000007810670 (^B) crc32c_vpmsum_cra_init
> > >>>>> c008000007810690 (^B) crc32c_vpmsum_setkey
> > >>>>
> > >>>> Hi Ravi,
> > >>>>
> > >>>> I have never seen this before,
> > 
> > Simply do:
> > 
> >   # crash vmcore vmlinux
> >   crash> sym -M
> >   c008000007810000 MODULE START: crc32c_vpmsum
> >   c008000007810000 (^R) __crc32c_vpmsum
> >   c008000007810670 (^B) crc32c_vpmsum_cra_init
> > 
> > But cmd_mod() seems to be doing right thing:
> > 
> >   crash> mod -s crc32c_vpmsum
> >   crash> sym -M
> >   c008000007810000 MODULE START: crc32c_vpmsum
> >   c008000007810000 (T) __crc32c_vpmsum
> >   c008000007810670 (t) crc32c_vpmsum_cra_init
> 
> Yeah, although I don't have crc32c_vpmsum module installed on my
> RHEL7 host system, I don't see it with any other modules.  I'll
> provision a 5.0.0-based system and see if it happens there.

OK, I see the problem with a 5.1.0-0.rc1 kernel.  I'll take a look
at also addressing it from the crash side.

Thanks,
  Dave  

> > 
> > >>>> but nonetheless, it does seem that Steve's patch
> > >>>> to the trace.c module is the better course of action.  Does it work OK
> > >>>> for you?
> > 
> > Yes Steve's patch fixes trace segfault for me.
> 
> Ok good, thanks.
> 
> I've cc'd this to the maintainer -- Xu, can you please review the patchset?
> 
> Thanks,
>   Dave
>  
> 
> 

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility



[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux