----- Original Message ----- > OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> writes: > > >> I'm thinking we should clarify that error message, perhaps by storing the > >> cpu > >> number in si->cpu, and displaying it when si->slab is NULL? > > > > Just a idea for now though (means not tested error path at all), how > > about the following? > > > > We know already slab pointer at that point. So, this sets si->slab > > temporarily. (and slub_page_objects() just uses slab in argument, not > > si->slab). > > BTW, if we want much more precise error report, IMO, it would be better > to refactoring first. > > E.g. get_freepointer() can be for both of cpu_slab and page freelist. > So, we may want to report which one. But we don't bring cpu_slab > pointer in current code, and no generic function to get cpu_slab pointer. > > And I don't know whether some sort of big refactoring is acceptable for > crash project. If it is acceptable, I might be able to help more or > less. I guess it depends upon the risk vs. reward with respect to what a "big refactoring" would consist of? In any case, I wanted to get your 2 patches checked in because I need to get crash-7.1.5 released soon. But please feel free to post any updates. Thanks for all your help so far, Dave > > Thanks. > -- > OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> > -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
