On Tue, 2011-03-01 at 00:13 +0000, Montgomery, Bob wrote:
> On Mon, 2011-02-28 at 21:59 +0000, Dave Anderson wrote:
> >
> > ----- Original Message -----
> > > On Thu, 2011-02-24 at 15:18 +0000, Dave Anderson wrote:
> > > >
> > > > ----- Original Message -----
> > > > > While testing my search patch, I kicked off an unconstrained physical
> > > > > search on a live session and hung the machine so thoroughly that it
> > > > > required a visit to the machine room to physically unplug it to get the
> > > > > remote console back up. Coincidence? Or should physical address search
> > > > > on a live session be constrained somehow for safety?
>
> I'm guessing that's bad :-) I'll implement the rejector code in the
> physical search, and see if I can avoid a trip to the machine room.
Something like this? It seems to be surviving physical searches on my
live session now. Any reason this would thwart the purpose of the
physical search in any way? "But I wanted to search pci space..."
Bob Montgomery
--- memory.c.str 2011-02-28 17:22:01.000000000 -0700
+++ memory.c 2011-02-28 17:41:50.000000000 -0700
@@ -12205,6 +12205,7 @@ search_physical(ulonglong start_in, ulon
char *pagebuf;
ulong pct, pages_read, pages_checked;
time_t begin, finish;
+ ulong page;
pages_read = pages_checked = 0;
begin = finish = 0;
@@ -12230,8 +12231,9 @@ search_physical(ulonglong start_in, ulon
if (LKCD_DUMPFILE())
set_lkcd_nohash();
- if (!readmem(ppp, PHYSADDR, pagebuf, PAGESIZE(),
- "search page", RETURN_ON_ERROR|QUIET)) {
+ if (!phys_to_page(ppp, &page) ||
+ !readmem(ppp, PHYSADDR, pagebuf, PAGESIZE(),
+ "search page", RETURN_ON_ERROR|QUIET)) {
if (!next_physpage(ppp, &ppp))
break;
continue;
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
