Nguyen Anh Quynh wrote: > On 3/27/06, Dave Anderson <anderson@xxxxxxxxxx> wrote: > > Nguyen Anh Quynh wrote: > > > > > hi Dave, > > > > > > is there any good reason not to include Xen header files into crash > > > code? (for ex, i see that you have copied few Xen structures from > > > xenctrl.h) > > > > > > > At this point, nothing's etched in stone, as I'm really just scratching > > the xen surface. I don't want to explicitly include xenctrl.h given that > > the vast majority of crash users then wouldn't be able to build new > > versions of crash. Not to mention that xenctrl.h in turn includes a > > bunch of other xen-specific header files as well. And all I really need > > is the dumpfile header. > > i see the point. but then i would like to recommend a build-option for > Xen users, and it is OFF by default. and we better always use the file > headers provided by Xen code. Actually, the version I'm working with now doesn't need the vcpu_guest_context structure, since it's built into the kernel. By moving kernel_init(PRE_GDB) and verify_version() to the point just after gdb_session_init() is called, I get it for free. Dave
