On 07/02/25 19:02, Mark Brown wrote: > On Fri, Feb 07, 2025 at 11:58:10AM +0530, Vijendar Mukunda wrote: > >> + if (adata->acp_rev == ACP63_PCI_REV) { >> + } else { > Unless I find something major in the rest of the series I'll apply this > but it's much better to write these as case statements, that way if you > get additional types to handle it's easier to extend the code sensibly. > Please update this incrementally. Will push it as an incremental patch.
- References:
- [PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1 platforms
- From: Vijendar Mukunda
- [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform
- From: Vijendar Mukunda
- Re: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform
- From: Mark Brown
- [PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1 platforms
- Prev by Date: Re: [PATCH v6 0/4] Add static channel mapping between soundwire master and slave
- Next by Date: Re: [PATCH v2 05/13] gpio: max3191x: use gpiod_multi_set_value_cansleep
- Previous by thread: Re: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform
- Next by thread: [PATCH V3 17/25] ASoC: amd: ps: add soundwire wake interrupt handling
- Index(es):
![]() |