On Fri, Feb 07, 2025 at 11:58:10AM +0530, Vijendar Mukunda wrote: > + if (adata->acp_rev == ACP63_PCI_REV) { > + } else { Unless I find something major in the rest of the series I'll apply this but it's much better to write these as case statements, that way if you get additional types to handle it's easier to extend the code sensibly. Please update this incrementally.
Attachment:
signature.asc
Description: PGP signature
- Follow-Ups:
- References:
- [PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1 platforms
- From: Vijendar Mukunda
- [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform
- From: Vijendar Mukunda
- [PATCH V3 00/25] ASoC: amd: Add support for ACP7.0 & ACP7.1 platforms
- Prev by Date: Re: [PATCH 1/2] fixup! ASoC: Intel: soc-acpi-intel-ptl-match: add rt712_vb + rt1320 support
- Next by Date: [PATCH 1/4] PCI: pci_ids: add INTEL_HDA_PTL_H
- Previous by thread: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform
- Next by thread: Re: [PATCH V3 16/25] ASoC: amd: ps: add soundwire dma interrupts handling for ACP7.0 platform
- Index(es):
![]() |