Re: possible issue with ALSA: hda/realtek: Use codec SSID matching for Lenovo devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Hi Takashi,

Sorry for the delay I had a build pipeline problem.

Confirming your TIA patch works perfectly on my 16ARX8H. The TI amp is
detected and enabled correctly again.

We're including it in the nobara and cachyOS kernels.

Thank you,
Samantha Glocker

---
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4210bc8..453835b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10888,7 +10888,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x3869, "Lenovo Yoga7 14IAL7",
ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN),
  HDA_CODEC_QUIRK(0x17aa, 0x386e, "Legion Y9000X 2022 IAH7",
ALC287_FIXUP_CS35L41_I2C_2),
  SND_PCI_QUIRK(0x17aa, 0x386e, "Yoga Pro 7 14ARP8",
ALC285_FIXUP_SPEAKER2_TO_DAC1),
- HDA_CODEC_QUIRK(0x17aa, 0x386f, "Legion Pro 7 16ARX8H",
ALC287_FIXUP_TAS2781_I2C),
+ HDA_CODEC_QUIRK(0x17aa, 0x38a8, "Legion Pro 7 16ARX8H",
ALC287_FIXUP_TAS2781_I2C), /* this must match before PCI SSID
17aa:386f below */
  SND_PCI_QUIRK(0x17aa, 0x386f, "Legion Pro 7i 16IAX7",
ALC287_FIXUP_CS35L41_I2C_2),
  SND_PCI_QUIRK(0x17aa, 0x3870, "Lenovo Yoga 7 14ARB7",
ALC287_FIXUP_YOGA7_14ARB7_I2C),
  SND_PCI_QUIRK(0x17aa, 0x3877, "Lenovo Legion 7 Slim 16ARHA7",
ALC287_FIXUP_CS35L41_I2C_2),
---

On Fri, Jan 24, 2025 at 3:04 AM Samantha Glocker
<iam@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> The Texas Instruments amp was not detected on kernel 6.12.5.
>
> You've understood perfectly. The patch you provided also looks good.
>
> I just finished compiling a test kernel, I will report back tomorrow.
>
> Thank you,
>
> Samantha Glocker
>
> On Thu, Jan 23, 2025, 05:07 Takashi Iwai <tiwai@xxxxxxx> wrote:
>>
>> On Thu, 23 Jan 2025 03:00:29 +0100,
>> Samantha Glocker wrote:
>> >
>> > Hi Takashi,
>> >
>> > Yes confirming it's a regression. I haven't raised it on bug tracker
>> > because I was pretty sure I'd located the regression as above.
>> >
>> > Sound was working on 6.12.4, and non-working from 6.12.5 (thru 6.12.10)
>>
>> What exactly do you mean as "sound was working (or non-working)"?
>> I suppose it's about the speaker output.  Or anything else broken?
>> The symptom needs to be reported more clearly -- only few people own
>> crystal balls.
>>
>>
>> thanks,
>>
>> Takashi

Attachment: alsa-info.patched.working.6.12.10.zip
Description: Zip archive


[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux