Re: [PATCH v3 23/25] arm64: dts: renesas: Add da7212 audio codec node

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Wed, Nov 13, 2024 at 2:36 PM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
>
> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Add the da7212 audio codec node. Along with it regulators nodes were
> reworked to be able to re-use them on da7212.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> ---
>
> Changes in v3:
> - none
>
> Changes in v2:
> - none
>
>  .../boot/dts/renesas/rzg3s-smarc-som.dtsi     | 17 ++++++++++----
>  arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi  | 23 +++++++++++++++++++
>  2 files changed, 35 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> index 6e58d47d85b0..5ee9dac4aebb 100644
> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi
> @@ -63,7 +63,6 @@ vcc_sdhi0: regulator0 {
>                 enable-active-high;
>         };
>
> -#if SW_CONFIG2 == SW_ON
>         vccq_sdhi0: regulator1 {
>                 compatible = "regulator-gpio";
>                 regulator-name = "SDHI0 VccQ";
> @@ -73,8 +72,8 @@ vccq_sdhi0: regulator1 {
>                 gpios-states = <1>;
>                 states = <3300000 1>, <1800000 0>;
>         };
> -#else
> -       reg_1p8v: regulator1 {
> +
> +       reg_1p8v: regulator2 {
>                 compatible = "regulator-fixed";
>                 regulator-name = "fixed-1.8V";
>                 regulator-min-microvolt = <1800000>;
> @@ -82,9 +81,17 @@ reg_1p8v: regulator1 {
>                 regulator-boot-on;
>                 regulator-always-on;
>         };
> -#endif
>
> -       vcc_sdhi2: regulator2 {
> +       reg_3p3v: regulator3 {
> +               compatible = "regulator-fixed";
> +               regulator-name = "fixed-3.3V";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +               regulator-boot-on;
> +               regulator-always-on;
> +       };
> +
> +       vcc_sdhi2: regulator4 {
>                 compatible = "regulator-fixed";
>                 regulator-name = "SDHI2 Vcc";
>                 regulator-min-microvolt = <3300000>;
> diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> index 4509151344c4..4aa99814b808 100644
> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi
> @@ -68,6 +68,29 @@ &i2c0 {
>         status = "okay";
>
>         clock-frequency = <1000000>;
> +
> +       da7212: codec@1a {
> +               compatible = "dlg,da7212";
> +               reg = <0x1a>;
> +
> +               #sound-dai-cells = <0>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;

make dtbs_check:

    arch/arm64/boot/dts/renesas/r9a08g045s33-smarc.dtb: codec@1a:
Unevaluated properties are not allowed ('#address-cells',
'#size-cells' were unexpected)
            from schema $id:
http://devicetree.org/schemas/sound/dlg,da7213.yaml#

> +
> +               clocks = <&versa3 1>;
> +               clock-names = "mclk";
> +
> +               dlg,micbias1-lvl = <2500>;
> +               dlg,micbias2-lvl = <2500>;
> +               dlg,dmic-data-sel = "lrise_rfall";
> +               dlg,dmic-samplephase = "between_clkedge";
> +               dlg,dmic-clkrate = <3000000>;
> +
> +               VDDA-supply = <&reg_1p8v>;
> +               VDDSP-supply = <&reg_3p3v>;
> +               VDDMIC-supply = <&reg_3p3v>;
> +               VDDIO-supply = <&reg_1p8v>;
> +       };
>  };

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds