Re: [PATCH 0/2] Fix beep notifications by Thinkpad's ACPI firmware

[Takashi Iwai <tiwai@xxxxxxx>]

On Sat, 02 Nov 2024 23:45:33 +0100,
Jarosław Janik wrote:
> 
> On 11/2/24 09:27, Takashi Iwai wrote:
> 
> > For checking the runtime-suspend, at best check the sysfs file entry.
> > e.g. cat /sys/bus/hdaudio/devices/hdaudioC0D0/power/runtime_status
> 
> OK, so - just to be sure - I verified my assumptions about PM state of
> HDA controller when "nothing interesting is happening" (suspended) and
> for a short while after I generate a beep on a console (active) - so not
> a huge surprise here :)

A beep sound triggered via the input beep device -- the one from
HD-audio driver, not from pcspkr -- does resume the runtime suspend.
So it's no surprise that it works.

OTOH, a question is rather the other route -- the beep via pcspkr
driver -- if this beep still works while the HD-audio is runtime
suspended: that's the interesting point.  Could you check that?
You can figure out which input device corresponds what, and try to
trigger directly there.

Also, one more question is whether the beep tone persists if you mute
the volume on the HD-audio (e.g. set "Speaker Playback Switch" to
off).  The beep tone at shutdown should be gone in this state, too.

> > As you see, the simple beeping stuff is really complex due to its
> > history.  Although it's a legacy feature, a few people still love it,
> > hence it can't go away soon :)
> 
> OK, so (again - just to be sure) - I understand that you are going to
> revert that patch this is all about (no more tests or whatever needed
> from my side)?

Yes, the revert is on the way to 6.12-rc7.


thanks,

Takashi