Re: [PATCH 0/2] Fix beep notifications by Thinkpad's ACPI firmware

[Takashi Iwai <tiwai@xxxxxxx>]

On Thu, 31 Oct 2024 17:43:18 +0100,
Jarosław Janik wrote:
> 
> On 31.10.2024 17:21, Takashi Iwai wrote:
> > Hm, so the beep works even if the HD-audio device is runtime-suspended
> > before shutdown?  Also, beeping at suspend/resume works no matter
> > whether runtime-suspended or not?
> 
> Well, to what I recall - my (current) Thinkpad has never beeped on
> shutdown, other than that - without your "extra muting" patch - yes -
> beeping in every other circumstances works no matter if HDA controller
> is in PM suspend or not; this is what I've got used to for many years of
> using Thinkpads.

Do you mean about the beep emitted via thinkpad_acpi stuff or the
normal beep via terminal etc?  The latter must work even with the
patch, but the question is only about the former.  And that's the case
for the shutdown beep tone.

You can pass snd_hda_intel.beep_mode=0 option to disable HD-audio
beep, verify the device being runtime-suspended, and check whether the
beep via thinkpad_acpi still works (after reverting).

> And one more thing - with your patch - beeping is not muted on my laptop
> completely, you can still hear it if you are in a quiet room, it's just
> very "weak".

It might be because there can be two routes of beep tone; one via
HD-audio and another internally.


thanks,

Takashi