Re: [PATCH] ASoC: cs42l51: Fix some error handling paths in cs42l51_probe()

[Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>]

On Sat, Oct 26, 2024 at 10:46:34PM +0200, Christophe JAILLET wrote:
> If devm_gpiod_get_optional() fails, we need to disable previously enabled
> regulators, as done in the other error handling path of the function.
> 
> Also, gpiod_set_value_cansleep(, 1) needs to be called to undo a
> potential gpiod_set_value_cansleep(, 0).
> If the "reset" gpio is not defined, this additional call is just a no-op.
> 
> This behavior is the same as the one already in the .remove() function.
> 
> Fixes: 11b9cd748e31 ("ASoC: cs42l51: add reset management")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles