RE: No sound on speakers X1 Carbon Gen 12

[Kailang <kailang@xxxxxxxxxxx>]

> -----Original Message-----
> From: Takashi Iwai <tiwai@xxxxxxx>
> Sent: Monday, October 21, 2024 4:57 PM
> To: Kailang <kailang@xxxxxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxx>; Dean Matthew Menezes
> <dean.menezes@xxxxxxxxxx>; stable@xxxxxxxxxxxxxxx;
> regressions@xxxxxxxxxxxxxxx; Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai
> <tiwai@xxxxxxxx>; Linux Sound System <linux-sound@xxxxxxxxxxxxxxx>; Greg
> KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Subject: Re: No sound on speakers X1 Carbon Gen 12
> 
> 
> External mail.
> 
> 
> 
> On Mon, 21 Oct 2024 10:38:48 +0200,
> Kailang wrote:
> >
> > But this platform need to assign model
> ALC287_FIXUP_LENOVO_THKPAD_WH_ALC1318.
> > It has a chance to broken amp IC.
> 
> Yes, if X1 Carbon Gen 12 is indeed the targeted model of the fix, it must be
> applied.  But we seem still missing some small piece...
> 
> > But I don't know why it doesn't have output from speaker.
> 
> The diff of COEF dump showed at NID 0x20:
> (working)    Coeff 0x10: 0x8006
> (broken)     Coeff 0x10: 0x8806
> (working)    Coeff 0x46: 0x0004
> (broken)     Coeff 0x46: 0x0404
> It shouldn't be a problem to leave the bit 0x800 to COEF 0x10, I suppose?
> 
> > Maybe could run hda_verb to get COEF value. To get NID 0x5A index 0 value.
> 
> Dean, please run hda-verb program (as root) like:
>   hda-verb /dev/snd/hwC0D0 0x5a SET_COEF_INDEX 0x00
>   hda-verb /dev/snd/hwC0D0 0x5a GET_PROC_COEF 0
> 
> and give the outputs on both working and non-working cases.
> 
> hda-verb should be included in alsa-utils.

Dean,
Please also get the value via music playing.

> 
> 
> Takashi
> 
> >
> > > -----Original Message-----
> > > From: Takashi Iwai <tiwai@xxxxxxx>
> > > Sent: Monday, October 21, 2024 4:24 PM
> > > To: Kailang <kailang@xxxxxxxxxxx>
> > > Cc: Takashi Iwai <tiwai@xxxxxxx>; Dean Matthew Menezes
> > > <dean.menezes@xxxxxxxxxx>; stable@xxxxxxxxxxxxxxx;
> > > regressions@xxxxxxxxxxxxxxx; Jaroslav Kysela <perex@xxxxxxxx>;
> > > Takashi Iwai <tiwai@xxxxxxxx>; Linux Sound System
> > > <linux-sound@xxxxxxxxxxxxxxx>; Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Subject: Re: No sound on speakers X1 Carbon Gen 12
> > >
> > >
> > > External mail.
> > >
> > >
> > >
> > > On Mon, 21 Oct 2024 10:19:53 +0200,
> > > Kailang wrote:
> > > >
> > > > Change to below model.
> > > > +     SND_PCI_QUIRK(0x17aa, 0x231e, "Thinkpad",
> > > ALC287_FIXUP_THINKPAD_I2S_SPK),
> > > > +     SND_PCI_QUIRK(0x17aa, 0x231f, "Thinkpad",
> > > > + ALC287_FIXUP_THINKPAD_I2S_SPK),
> > > >
> > > > The speaker will have output. Right?
> > >
> > > FWIW, that was what I asked in
> > >   https://lore.kernel.org/87h697jl6c.wl-tiwai@xxxxxxx
> > > and Dean replied that the speaker worked with it.
> > > (His reply missed Cc, so it didn't appear in the thread, unfortunately).
> > >
> > >
> > > Takashi
> > >
> > > > > -----Original Message-----
> > > > > From: Takashi Iwai <tiwai@xxxxxxx>
> > > > > Sent: Monday, October 21, 2024 2:59 PM
> > > > > To: Dean Matthew Menezes <dean.menezes@xxxxxxxxxx>
> > > > > Cc: Takashi Iwai <tiwai@xxxxxxx>; Kailang <kailang@xxxxxxxxxxx>;
> > > > > stable@xxxxxxxxxxxxxxx; regressions@xxxxxxxxxxxxxxx; Jaroslav
> > > > > Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Linux
> > > > > Sound System <linux-sound@xxxxxxxxxxxxxxx>; Greg KH
> > > > > <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > > Subject: Re: No sound on speakers X1 Carbon Gen 12
> > > > >
> > > > >
> > > > > External mail.
> > > > >
> > > > >
> > > > >
> > > > > On Mon, 21 Oct 2024 03:30:13 +0200, Dean Matthew Menezes wrote:
> > > > > >
> > > > > > I can confirm that the original fix does not bring back the
> > > > > > speaker output.  I have attached both outputs for alsa-info.sh
> > > > >
> > > > > Thanks!  This confirms that the only significant difference is
> > > > > the COEF data between working and patched-non-working cases.
> > > > >
> > > > > Kailang, I guess this model (X1 Carbon Gen 12) isn't with
> > > > > ALC1318, hence your quirk rather influences badly.  Or may the
> > > > > GPIO3 workaround have the similar effect?
> > > > >
> > > > > As of now, the possible fix is to simply remove the quirk
> > > > > entries for
> > > ALC1318.
> > > > > But I'd need to know which model was targeted for your original
> > > > > fix in commit
> > > > > 1e707769df07 and whether the regressed model is with ALC1318.
> > > > >
> > > > >
> > > > > Takashi