Re: No sound on speakers X1 Carbon Gen 12

[Takashi Iwai <tiwai@xxxxxxx>]

On Wed, 16 Oct 2024 23:18:02 +0200,
Dean Matthew Menezes wrote:
> 
> OK I have run the script and have attached the outputs.

Please avoid top-posting.

> On Wed, 16 Oct 2024 at 04:20, Takashi Iwai <tiwai@xxxxxxx> wrote:
> >
> > On Wed, 16 Oct 2024 07:56:09 +0200,
> > Linux regression tracking (Thorsten Leemhuis) wrote:
> > >
> > > On 16.10.24 07:42, Greg KH wrote:
> > > > On Tue, Oct 15, 2024 at 07:47:22PM -0500, Dean Matthew Menezes wrote:
> > > >> I am not getting sound on the speakers on my Thinkpad X1 Carbon Gen 12
> > > >> with kernel 6.11.2  The sound is working in kernel 6.8
> > > >
> > > > Can you use 'git bisect' to track down the offending change?
> > >
> > > Yeah, that would help a lot.
> > >
> > > But FWIW, I CCed the audio maintainers and the sound mailing list, with
> > > a bit of luck they might have an idea.
> > >
> > > You might also want to publish your dmesg files from the latest working
> > > and the first broken kernel, that gives people a chance to spot obvious
> > > problems. Ohh, and runing alsa-info.sh and publishing the output could
> > > help, too.
> >
> > Yes, alsa-info.sh outputs are really needed for debugging, especially
> > because Lenovo has (literally) hundreds of different models.
> >
> > Please run the script with --no-upload option and attach the outputs
> > from both working and non-working cases.

So the problem seems to be the newly added quirk for fixing S4 issue
forgot the existing quirk for the speaker.  The patch below should
address the problem.  Please give it a try.


thanks,

Takashi

-- 8< --
From: Takashi Iwai <tiwai@xxxxxxx>
Subject: [PATCH] ALSA: hda/realtek: Fix speaker output on Thinkpad X1 Carbon Gen 12

The fix for S4 issue on some Thinkpad models in commit 1e707769df07
("ALSA: hda/realtek - Set GPIO3 to default at S4 state for Thinkpad
with ALC1318") caused a regression of the missing speaker output, as
the newly added quirk entry forgot that there was an implicitly
applied quirk matching with the pincfg, which determines the speaker
DAC connection and the I2S setup.

Correct the chained quirk entry to point to the right one,
ALC287_FIXUP_THINKPAD_I2S_SPK, to address the regression.

Fixes: 1e707769df07 ("ALSA: hda/realtek - Set GPIO3 to default at S4 state for Thinkpad with ALC1318")
Reported-by: Dean Matthew Menezes <dean.menezes@xxxxxxxxxx>
Closes: https://lore.kernel.org/all/CAEkK70Tke7UxMEEKgRLMntSYeMqiv0PC8st72VYnBVQD-KcqVw@xxxxxxxxxxxxxx/
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3bbf5fab2881..cc77b4967400 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10097,7 +10097,7 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc287_fixup_lenovo_thinkpad_with_alc1318,
 		.chained = true,
-		.chain_id = ALC269_FIXUP_THINKPAD_ACPI
+		.chain_id = ALC287_FIXUP_THINKPAD_I2S_SPK
 	},
 	[ALC256_FIXUP_CHROME_BOOK] = {
 		.type = HDA_FIXUP_FUNC,
-- 
2.43.0