Re: [PATCH v2 7/9] ASoC: loongson: Add I2S controller driver as platform device

[Binbin Zhou <zhoubb.aaron@xxxxxxxxx>]

Hi Mark:

On Thu, Sep 26, 2024 at 1:45 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Thu, Sep 26, 2024 at 08:03:55AM +0600, Binbin Zhou wrote:
>
> > I will rewrite the dependency between the card and the DAI driver, as follows:
>
> > config SND_SOC_LOONGSON_CARD
> >         tristate "Loongson Sound Card Driver"
> >         depends on LOONGARCH || COMPILE_TEST
> >         select SND_SOC_LOONGSON_I2S_PCI if PCI
> >         select SND_SOC_LOONGSON_I2S_PLATFORM if OF
>
> > config SND_SOC_LOONGSON_I2S_PCI
> >         tristate "Loongson I2S-PCI Device Driver"
> >         select REGMAP_MMIO
>
> > config SND_SOC_LOONGSON_I2S_PLATFORM
> >         tristate "Loongson I2S controller as platform device"
> >         select REGMAP_MMIO
> >         select SND_SOC_GENERIC_DMAENGINE_PCM
>
> That looks good apart from the PCI and platform drivers should probably
> also have a
>
>         depends on LOONGARCH || COMPILE_TEST
>
> so they're not shown on architectures where they can't be used unless
> doing testing.

OK, I will add it in the V3 patchset.

Thanks.
Binbin